[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/4] reset: Add RESET_TYPE_WAKEUP
|
From: |
Juraj Marcin |
|
Subject: |
[PATCH 2/4] reset: Add RESET_TYPE_WAKEUP |
|
Date: |
Tue, 6 Aug 2024 18:07:52 +0200 |
Some devices need to distinguish cold start reset from waking up from a
suspended state. This patch adds new value to the enum, and updates the
i386 wakeup method to use this new reset type.
Signed-off-by: Juraj Marcin <jmarcin@redhat.com>
---
docs/devel/reset.rst | 7 +++++++
hw/i386/pc.c | 2 +-
include/hw/resettable.h | 2 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/docs/devel/reset.rst b/docs/devel/reset.rst
index 9746a4e8a0..30c9a0cc2b 100644
--- a/docs/devel/reset.rst
+++ b/docs/devel/reset.rst
@@ -44,6 +44,13 @@ The Resettable interface handles reset types with an enum
``ResetType``:
value on each cold reset, such as RNG seed information, and which they
must not reinitialize on a snapshot-load reset.
+``RESET_TYPE_WAKEUP``
+ This type is used when the machine is woken up from a suspended state (deep
+ sleep, suspend-to-ram). Devices that must not be reset to their initial state
+ after wake-up (for example virtio-mem) can use this state to differentiate
+ cold start from wake-up can use this state to differentiate cold start from
+ wake-up.
+
Devices which implement reset methods must treat any unknown ``ResetType``
as equivalent to ``RESET_TYPE_COLD``; this will reduce the amount of
existing code we need to change if we add more types in future.
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index ccb9731c91..49efd0a997 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1716,7 +1716,7 @@ static void pc_machine_reset(MachineState *machine,
ResetType type)
static void pc_machine_wakeup(MachineState *machine)
{
cpu_synchronize_all_states();
- pc_machine_reset(machine, RESET_TYPE_COLD);
+ pc_machine_reset(machine, RESET_TYPE_WAKEUP);
cpu_synchronize_all_post_reset();
}
diff --git a/include/hw/resettable.h b/include/hw/resettable.h
index 7e249deb8b..edb1f1361b 100644
--- a/include/hw/resettable.h
+++ b/include/hw/resettable.h
@@ -29,6 +29,7 @@ typedef struct ResettableState ResettableState;
* Types of reset.
*
* + Cold: reset resulting from a power cycle of the object.
+ * + Wakeup: reset resulting from a wake-up from a suspended state.
*
* TODO: Support has to be added to handle more types. In particular,
* ResettableState structure needs to be expanded.
@@ -36,6 +37,7 @@ typedef struct ResettableState ResettableState;
typedef enum ResetType {
RESET_TYPE_COLD,
RESET_TYPE_SNAPSHOT_LOAD,
+ RESET_TYPE_WAKEUP,
} ResetType;
/*
--
2.45.2
- [PATCH 0/4] virtio-mem: Implement support for suspend+wake-up with plugged memory, Juraj Marcin, 2024/08/06
- [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP,
Juraj Marcin <=
- Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP, David Hildenbrand, 2024/08/06
- Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP, Peter Maydell, 2024/08/08
- Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP, Juraj Marcin, 2024/08/08
- Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP, David Hildenbrand, 2024/08/08
- Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP, Peter Maydell, 2024/08/08
- Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP, David Hildenbrand, 2024/08/08
- Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP, Peter Maydell, 2024/08/08
- Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP, David Hildenbrand, 2024/08/08
- Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP, Peter Maydell, 2024/08/08
- Re: [PATCH 2/4] reset: Add RESET_TYPE_WAKEUP, David Hildenbrand, 2024/08/08