Re: [RFC PATCH] qapi: Generate QAPI files using qapi/ for generated header paths

[Daniel P . Berrangé]

On Wed, Aug 07, 2024 at 12:50:26PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé <berrange@redhat.com> writes:
> 
> > On Wed, Aug 07, 2024 at 11:34:06AM +0200, Philippe Mathieu-Daudé wrote:
> >> QAPI script generates headers under the qapi/ directory,
> >> so use this prefix in generated header paths, keeping
> >> all QAPI under the qapi/ namespace.
> >
> > Err that's not always the case is it ?
> 
> Yup.  We generate into the current directory by default, but you can set
> another one with --output-dir.
> 
> > For the main QMP schema, it generates under $BUILDDIR/qapi/,
> > but there are other schemas such as QGA, which is generated
> > under $BUILDDIR/qga/
> 
> I think we could prepend the argument of --output-dir instead.
> 
> > It is confusing that we have both shared stuff and QMP schema
> > only stuff under the same location.
> 
> Which stuff in which location?

There are multiple directories with 'qapi' in their name

 - $SRC/include/qapi - all generic stuff for any consumer of QAPI
 - $SRC/qapi - impl of generic stuff from $SRC/include/qapi, but
               also the QMP schema for machine emulator
 - $BUILD/qapi - generated code for QMP schema for machine emulator

I find it confusing that we have both generic QAPI code and the main
machine emulator QMP schema in directories sharing the same 'qapi'
name.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|