[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/6] configure: Avoid use of param. expansion when using gdb_vers
|
From: |
Alex Bennée |
|
Subject: |
[PATCH 4/6] configure: Avoid use of param. expansion when using gdb_version |
|
Date: |
Wed, 7 Aug 2024 12:40:57 +0100 |
From: Gustavo Romero <gustavo.romero@linaro.org>
$gdb_version is now used in more than one conditional case and its usage
in such cases may increase in the future. Therefore, avoid using shell
parameter expansion when using it by setting gdb_version to its final
form.
Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Message-Id: <20240804161850.2646299-3-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
configure | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/configure b/configure
index a3aa257fd3..97de85d710 100755
--- a/configure
+++ b/configure
@@ -1103,8 +1103,10 @@ fi
# gdb test
if test -n "$gdb_bin"; then
- gdb_version=$($gdb_bin --version | head -n 1)
- if version_ge ${gdb_version##* } 9.1; then
+ gdb_version_string=$($gdb_bin --version | head -n 1)
+ # Extract last field in the version string
+ gdb_version=${gdb_version_string##* }
+ if version_ge $gdb_version 9.1; then
gdb_arches=$($python "$source_path/scripts/probe-gdb-support.py"
$gdb_bin)
else
gdb_bin=""
@@ -1673,7 +1675,7 @@ for target in $target_list; do
echo "GDB=$gdb_bin" >> $config_target_mak
fi
- if test "${gdb_arches#*aarch64}" != "$gdb_arches" && version_ge
${gdb_version##* } 15.0; then
+ if test "${gdb_arches#*aarch64}" != "$gdb_arches" && version_ge
$gdb_version 15.0; then
echo "GDB_HAS_MTE=y" >> $config_target_mak
fi
--
2.39.2
- [PATCH 0/6] A few more fixes for 9.1, Alex Bennée, 2024/08/07
- [PATCH 2/6] Makefile: trigger re-configure on updated pythondeps, Alex Bennée, 2024/08/07
- [PATCH 4/6] configure: Avoid use of param. expansion when using gdb_version,
Alex Bennée <=
- [PATCH 3/6] configure: Fix arch detection for GDB_HAS_MTE, Alex Bennée, 2024/08/07
- [PATCH 1/6] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot, Alex Bennée, 2024/08/07
- [PATCH 5/6] configure: Fix GDB version detection for GDB_HAS_MTE, Alex Bennée, 2024/08/07
- [PATCH 6/6] scripts/checkpatch: more checks on files imported from Linux, Alex Bennée, 2024/08/07