qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 03/20] target/riscv: Introduce elp state and enabling cont


From: Deepak Gupta
Subject: Re: [PATCH v3 03/20] target/riscv: Introduce elp state and enabling controls for zicfilp
Date: Wed, 7 Aug 2024 11:46:04 -0700

On Wed, Aug 07, 2024 at 10:56:12AM +1000, Richard Henderson wrote:
On 8/7/24 10:06, Deepak Gupta wrote:
+/* enum for branch tracking state in cpu/hart */
+typedef enum {
+    NO_LP_EXPECTED = 0,
+    LP_EXPECTED = 1,
+} cfi_elp;

I know this is language is in the spec, but would it make more sense to use

 bool elp_expected;

?

Sounds reasonable to me. Will take the suggestion.


If not, Coding Style requires CamelCase for typedefs.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]