|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH-for-9.1 v2 4/4] hw/ssi/pnv_spi: Fixes Coverity CID 1558831 |
Date: | Wed, 7 Aug 2024 22:28:53 +0200 |
User-agent: | Mozilla Thunderbird |
On 7/8/24 22:28, Philippe Mathieu-Daudé wrote:
From: Chalapathi V <chalapathi.v@linux.ibm.com> In this commit the following coverity scan defect has been fixed CID 1558831: Resource leaks (RESOURCE_LEAK) Variable "rsp_payload" going out of scope leaks the storage it points to. Fixes: Coverity CID 1558831 Signed-off-by: Chalapathi V <chalapathi.v@linux.ibm.com> Fixes: b4cb930e40 ("hw/ssi: Extend SPI model")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
[PMD: Rebased on previous commit (returning earlier)] Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/ssi/pnv_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ssi/pnv_spi.c b/hw/ssi/pnv_spi.c index 05e6afc11e..eadc36fa86 100644 --- a/hw/ssi/pnv_spi.c +++ b/hw/ssi/pnv_spi.c @@ -239,6 +239,7 @@ static void transfer(PnvSpi *s, PnvXferBuffer *payload) } } spi_response(s, s->N1_bits, rsp_payload); + pnv_spi_xfer_buffer_free(rsp_payload); }static inline uint8_t get_seq_index(PnvSpi *s)
[Prev in Thread] | Current Thread | [Next in Thread] |