RE: [PATCH v4 00/15] hw/misc/aspeed_hace: Fix SG Accumulative Hash Calculations

[Alejandro Zeise]

Hi Phil,

> This message has originated from an External Source. Please use proper 
> judgment and caution when opening attachments, clicking links, or responding 
> to this email.
>
>
> Hi Alejandro,
>
> On 7/8/24 21:51, Alejandro Zeise wrote:
> > The goal of this patch series is to fix accumulative hashing support 
> > in the Aspeed HACE module. The issue that stemmed this patch was a 
> > failure to boot an OpenBMC image using the "ast2600-evb" machine. The 
> > U-boot
> > 2019.04 loader failed to verify image hashes.
>
>
> > Alejandro Zeise (15):
> >    crypto: accumulative hashing API
> >    crypto/hash-glib: Implement new hash API
> >    crypto/hash-gcrypt: Implement new hash API
> >    crypto/hash-gnutls: Implement new hash API
> >    crypto/hash-nettle: Implement new hash API
> >    crypto/hash-afalg: Implement new hash API
> >    crypto/hash: Implement and use new hash API
> >    tests/unit/test-crypto-hash: accumulative hashing
> >    crypto/hash-glib: Remove old hash API functions
> >    crypto/hash-gcrypt: Remove old hash API functions
> >    crypto/hash-gnutls: Remove old hash API functions
> >    crypto/hash-nettle: Remove old hash API functions
> >    crypto/hash-afalg: Remove old hash API functions
> >    crypto/hashpriv: Remove old hash API function
> >    hw/misc/aspeed_hace: Fix SG Accumulative hashing
>
> >   13 files changed, 753 insertions(+), 283 deletions(-)

> Even without the unit test this is still more than 700 LoC, which seems a 
> huge patchset to merge while we are in freeze period. Do you expect this to 
> be in the next v9.1.0 release?
>
> Regards,
>
>  Phil.

I do understand this involves of changes, and don't expect this to be in the 
next release.
I'm not quite familiar with the process regarding versioning (this is my first 
ever patch), but I do not see a need to rush these changes.

Thanks,
Alejandro