RE: [PATCH v4 03/15] crypto/hash-gcrypt: Implement new hash API

[Alejandro Zeise]

> On Wed, Aug 07, 2024 at 07:51:10PM +0000, Alejandro Zeise wrote:
> > Implements the new hashing API in the gcrypt hash driver.
> > Supports creating/destroying a context, updating the context with 
> > input data and obtaining an output hash.
> >
> > Signed-off-by: Alejandro Zeise <alejandro.zeise@seagate.com>
> > ---
> >  crypto/hash-gcrypt.c | 79 
> > ++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 79 insertions(+)
> >
> > diff --git a/crypto/hash-gcrypt.c b/crypto/hash-gcrypt.c index 
> > 829e48258d..e05511cafa 100644
> > --- a/crypto/hash-gcrypt.c
> > +++ b/crypto/hash-gcrypt.c
> > @@ -1,6 +1,7 @@
> >  /*
> >   * QEMU Crypto hash algorithms
> >   *
> > + * Copyright (c) 2024 Seagate Technology LLC and/or its Affiliates
> >   * Copyright (c) 2016 Red Hat, Inc.
> >   *
> >   * This library is free software; you can redistribute it and/or @@ 
> > -110,7 +111,85 @@ qcrypto_gcrypt_hash_bytesv(QCryptoHashAlgorithm alg,
> >      return -1;
> >  }
> >
> > +static
> > +QCryptoHash *qcrypto_gcrypt_hash_new(QCryptoHashAlgorithm alg, Error 
> > +**errp) {
> > +    QCryptoHash *hash = NULL;
> > +
> > +    if (!qcrypto_hash_supports(alg)) {
> > +        error_setg(errp,
> > +                   "Unknown hash algorithm %d",
> > +                   alg);
> > +    } else {
> > +        hash = g_new(QCryptoHash, 1);
> > +        hash->alg = alg;
> > +        hash->opaque = g_new(gcry_md_hd_t, 1);
> > +
> > +        gcry_md_open((gcry_md_hd_t *) hash->opaque, 
> > qcrypto_hash_alg_map[alg], 0);
> > +    }
> > +
> > +    return hash;
> > +}
> > +
> > +static
> > +void qcrypto_gcrypt_hash_free(QCryptoHash *hash) {
> > +    gcry_md_hd_t *ctx = hash->opaque;
> > +
> > +    if (ctx) {
> > +        gcry_md_close(*ctx);
> > +        g_free(ctx);
> > +    }
> > +
> > +    g_free(hash);
> > +}
> > +
> > +
> > +static
> > +int qcrypto_gcrypt_hash_update(QCryptoHash *hash,
> > +                               const struct iovec *iov,
> > +                               size_t niov,
> > +                               Error **errp) {
> > +    gcry_md_hd_t *ctx = hash->opaque;
> > +
> > +    for (int i = 0; i < niov; i++) {
> > +        gcry_md_write(*ctx, iov[i].iov_base, iov[i].iov_len);
>
>   int ret = gcry_md_write(*ctx, iov[i].iov_base, iov[i].iov_len);
>   if (ret != 0) {
>       error_setg(....)
>       return -1;
>   }
>
>
> With regards,
> Daniel

gcry_md_write() is declared as void which is why I had no error variable 
present.

Thanks,
Alejandro