[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-9.1] target/m68k: Always return a temporary from gen_lea_mode
|
From: |
Richard Henderson |
|
Subject: |
[PATCH for-9.1] target/m68k: Always return a temporary from gen_lea_mode |
|
Date: |
Tue, 13 Aug 2024 10:07:37 +1000 |
Returning a raw areg does not preserve the value if the areg
is subsequently modified. Fixes, e.g. "jsr (sp)", where the
return address is pushed before the branch.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2483
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/m68k/translate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index fb5ecce0c3..5e2be846b7 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -723,7 +723,9 @@ static TCGv gen_lea_mode(CPUM68KState *env, DisasContext *s,
}
/* fallthru */
case 2: /* Indirect register */
- return get_areg(s, reg0);
+ tmp = tcg_temp_new();
+ tcg_gen_mov_i32(tmp, get_areg(s, reg0));
+ return tmp;
case 4: /* Indirect predecrememnt. */
if (opsize == OS_UNSIZED) {
return NULL_QREG;
--
2.43.0
- [PATCH for-9.1] target/m68k: Always return a temporary from gen_lea_mode,
Richard Henderson <=