Re: [PATCH v1 10/15] tcg/riscv: Implement vector not/neg ops

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 10/15] tcg/riscv: Implement vector not/neg ops

From:	Richard Henderson
Subject:	Re: [PATCH v1 10/15] tcg/riscv: Implement vector not/neg ops
Date:	Wed, 14 Aug 2024 19:45:59 +1000
User-agent:	Mozilla Thunderbird

On 8/13/24 21:34, LIU Zhiwei wrote:

@@ -2312,6 +2314,12 @@ static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc,
      case INDEX_op_xor_vec:
          tcg_out_opc_vv(s, OPC_VXOR_VV, a0, a1, a2, true);
          break;
+    case INDEX_op_not_vec:
+        tcg_out_opc_vi(s, OPC_VXOR_VI, a0, a1, -1, true);
+        break;
+    case INDEX_op_neg_vec:
+        tcg_out_opc_vx(s, OPC_VRSUB_VX, a0, a1, TCG_REG_ZERO, true);
+        break;


Any reason not to use vrsub.vi?  Not wrong, just surprising.

Obviously, NOT does not require SEW change.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v1 08/15] tcg/riscv: Add support for basic vector opcodes, (continued)
- [PATCH v1 08/15] tcg/riscv: Add support for basic vector opcodes, LIU Zhiwei, 2024/08/13
  - Re: [PATCH v1 08/15] tcg/riscv: Add support for basic vector opcodes, Richard Henderson, 2024/08/14
    - Re: [PATCH v1 08/15] tcg/riscv: Add support for basic vector opcodes, LIU Zhiwei, 2024/08/19
  - Re: [PATCH v1 08/15] tcg/riscv: Add support for basic vector opcodes, Richard Henderson, 2024/08/14
    - Re: [PATCH v1 08/15] tcg/riscv: Add support for basic vector opcodes, LIU Zhiwei, 2024/08/19
    - Re: [PATCH v1 08/15] tcg/riscv: Add support for basic vector opcodes, Richard Henderson, 2024/08/20
- [PATCH v1 09/15] tcg/riscv: Implement vector cmp ops, LIU Zhiwei, 2024/08/13
  - Re: [PATCH v1 09/15] tcg/riscv: Implement vector cmp ops, Richard Henderson, 2024/08/14
    - Re: [PATCH v1 09/15] tcg/riscv: Implement vector cmp ops, LIU Zhiwei, 2024/08/27
- [PATCH v1 10/15] tcg/riscv: Implement vector not/neg ops, LIU Zhiwei, 2024/08/13
  - Re: [PATCH v1 10/15] tcg/riscv: Implement vector not/neg ops, Richard Henderson <=
    - Re: [PATCH v1 10/15] tcg/riscv: Implement vector not/neg ops, LIU Zhiwei, 2024/08/27
- [PATCH v1 11/15] tcg/riscv: Implement vector sat/mul ops, LIU Zhiwei, 2024/08/13
- [PATCH v1 12/15] tcg/riscv: Implement vector min/max ops, LIU Zhiwei, 2024/08/13
- [PATCH v1 13/15] tcg/riscv: Implement vector shs/v ops, LIU Zhiwei, 2024/08/13
- [PATCH v1 14/15] tcg/riscv: Implement vector roti/v/x shi ops, LIU Zhiwei, 2024/08/13
  - Re: [PATCH v1 14/15] tcg/riscv: Implement vector roti/v/x shi ops, Richard Henderson, 2024/08/14
    - Re: [PATCH v1 14/15] tcg/riscv: Implement vector roti/v/x shi ops, LIU Zhiwei, 2024/08/27
- [PATCH v1 15/15] tcg/riscv: Enable vector TCG host-native, LIU Zhiwei, 2024/08/13
  - Re: [PATCH v1 15/15] tcg/riscv: Enable vector TCG host-native, Richard Henderson, 2024/08/14
    - Re: [PATCH v1 15/15] tcg/riscv: Enable vector TCG host-native, LIU Zhiwei, 2024/08/27

Prev by Date: Re: [PATCH v1 09/15] tcg/riscv: Implement vector cmp ops
Next by Date: Re: [PATCH v1 14/15] tcg/riscv: Implement vector roti/v/x shi ops
Previous by thread: [PATCH v1 10/15] tcg/riscv: Implement vector not/neg ops
Next by thread: Re: [PATCH v1 10/15] tcg/riscv: Implement vector not/neg ops
Index(es):
- Date
- Thread