[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/21] configure: Avoid use of param. expansion when using gdb_ver
|
From: |
Alex Bennée |
|
Subject: |
[PULL 04/21] configure: Avoid use of param. expansion when using gdb_version |
|
Date: |
Thu, 15 Aug 2024 15:48:54 +0100 |
From: Gustavo Romero <gustavo.romero@linaro.org>
$gdb_version is now used in more than one conditional case and its usage
in such cases may increase in the future. Therefore, avoid using shell
parameter expansion when using it by setting gdb_version to its final
form.
Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Message-Id: <20240804161850.2646299-3-gustavo.romero@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240813202329.1237572-5-alex.bennee@linaro.org>
diff --git a/configure b/configure
index a3aa257fd3..97de85d710 100755
--- a/configure
+++ b/configure
@@ -1103,8 +1103,10 @@ fi
# gdb test
if test -n "$gdb_bin"; then
- gdb_version=$($gdb_bin --version | head -n 1)
- if version_ge ${gdb_version##* } 9.1; then
+ gdb_version_string=$($gdb_bin --version | head -n 1)
+ # Extract last field in the version string
+ gdb_version=${gdb_version_string##* }
+ if version_ge $gdb_version 9.1; then
gdb_arches=$($python "$source_path/scripts/probe-gdb-support.py"
$gdb_bin)
else
gdb_bin=""
@@ -1673,7 +1675,7 @@ for target in $target_list; do
echo "GDB=$gdb_bin" >> $config_target_mak
fi
- if test "${gdb_arches#*aarch64}" != "$gdb_arches" && version_ge
${gdb_version##* } 15.0; then
+ if test "${gdb_arches#*aarch64}" != "$gdb_arches" && version_ge
$gdb_version 15.0; then
echo "GDB_HAS_MTE=y" >> $config_target_mak
fi
--
2.39.2
- [PULL for 9.1 00/21] Some fixes for 9.1-rc3 (build, replay, docs, plugins), Alex Bennée, 2024/08/15
- [PULL 01/21] tests/avocado: Re-enable gdbsim-r5f562n8 testing U-Boot, Alex Bennée, 2024/08/15
- [PULL 02/21] Makefile: trigger re-configure on updated pythondeps, Alex Bennée, 2024/08/15
- [PULL 04/21] configure: Avoid use of param. expansion when using gdb_version,
Alex Bennée <=
- [PULL 07/21] target/i386: allow access_ptr to force slow path on failed probe, Alex Bennée, 2024/08/15
- [PULL 14/21] tests/avocado: replay_kernel.py add x86-64 q35 machine test, Alex Bennée, 2024/08/15
- [PULL 05/21] configure: Fix GDB version detection for GDB_HAS_MTE, Alex Bennée, 2024/08/15
- [PULL 06/21] scripts/checkpatch: more checks on files imported from Linux, Alex Bennée, 2024/08/15
- [PULL 03/21] configure: Fix arch detection for GDB_HAS_MTE, Alex Bennée, 2024/08/15
- [PULL 21/21] plugins: fix race condition with scoreboards, Alex Bennée, 2024/08/15
- [PULL 15/21] chardev: set record/replay on the base device of a muxed device, Alex Bennée, 2024/08/15
- [PULL 09/21] scripts/replay-dump.py: Update to current rr record format, Alex Bennée, 2024/08/15
- [PULL 16/21] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state, Alex Bennée, 2024/08/15