[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 18/21] savevm: Fix load_snapshot error path crash
|
From: |
Alex Bennée |
|
Subject: |
[PULL 18/21] savevm: Fix load_snapshot error path crash |
|
Date: |
Thu, 15 Aug 2024 15:49:08 +0100 |
From: Nicholas Piggin <npiggin@gmail.com>
An error path missed setting *errp, which can cause a NULL deref.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Message-Id: <20240813050638.446172-11-npiggin@gmail.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240813202329.1237572-19-alex.bennee@linaro.org>
diff --git a/migration/savevm.c b/migration/savevm.c
index 85958d7b09..6bb404b9c8 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -3288,6 +3288,7 @@ bool load_snapshot(const char *name, const char *vmstate,
/* Don't even try to load empty VM states */
ret = bdrv_snapshot_find(bs_vm_state, &sn, name);
if (ret < 0) {
+ error_setg(errp, "Snapshot can not be found");
return false;
} else if (sn.vm_state_size == 0) {
error_setg(errp, "This is a disk-only snapshot. Revert to it "
--
2.39.2
- [PULL 21/21] plugins: fix race condition with scoreboards, (continued)
- [PULL 21/21] plugins: fix race condition with scoreboards, Alex Bennée, 2024/08/15
- [PULL 15/21] chardev: set record/replay on the base device of a muxed device, Alex Bennée, 2024/08/15
- [PULL 09/21] scripts/replay-dump.py: Update to current rr record format, Alex Bennée, 2024/08/15
- [PULL 16/21] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state, Alex Bennée, 2024/08/15
- [PULL 19/21] docs: Fix some typos (found by typos) and grammar issues, Alex Bennée, 2024/08/15
- [PULL 10/21] scripts/replay-dump.py: rejig decoders in event number order, Alex Bennée, 2024/08/15
- [PULL 12/21] replay: allow runstate shutdown->running when replaying trace, Alex Bennée, 2024/08/15
- [PULL 13/21] Revert "replay: stop us hanging in rr_wait_io_event", Alex Bennée, 2024/08/15
- [PULL 11/21] tests/avocado: excercise scripts/replay-dump.py in replay tests, Alex Bennée, 2024/08/15
- [PULL 08/21] buildsys: Fix building without plugins on Darwin, Alex Bennée, 2024/08/15
- [PULL 18/21] savevm: Fix load_snapshot error path crash,
Alex Bennée <=
- [PULL 17/21] virtio-net: Use virtual time for RSC timers, Alex Bennée, 2024/08/15
- [PULL 20/21] docs/devel: update tcg-plugins page, Alex Bennée, 2024/08/15
- Re: [PULL for 9.1 00/21] Some fixes for 9.1-rc3 (build, replay, docs, plugins), Richard Henderson, 2024/08/15