Re: [PATCH v4 03/16] target/riscv: save and restore elp state on priv tr

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 03/16] target/riscv: save and restore elp state on priv tr

From:	Deepak Gupta
Subject:	Re: [PATCH v4 03/16] target/riscv: save and restore elp state on priv transitions
Date:	Thu, 15 Aug 2024 23:45:04 -0700

On Fri, Aug 16, 2024 at 12:59:43PM +1000, Richard Henderson wrote:

On 8/16/24 11:06, Deepak Gupta wrote:

@@ -546,6 +575,15 @@ void riscv_cpu_swap_hypervisor_regs(CPURISCVState *env)
     }
     bool current_virt = env->virt_enabled;
+    /*
+     * If zicfilp extension available and henvcfg.LPE = 1,
+     * then apply SPELP mask on mstatus
+     */
+    if (env_archcpu(env)->cfg.ext_zicfilp &&
+        get_field(env->henvcfg, HENVCFG_LPE)) {
+        mstatus_mask |= SSTATUS_SPELP;
+    }
+


I think this hunk belongs with the previous patch.


I kept it here because this save/restore of vsstatus with effective sstatus 
during
VS/VU <--> HS transition. ELP also needs to get saved/restored during these 
transitions.

Otherwise.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v4 00/16] riscv support for control flow integrity extensions, Deepak Gupta, 2024/08/15
- [PATCH v4 02/16] target/riscv: Introduce elp state and enabling controls for zicfilp, Deepak Gupta, 2024/08/15
  - Re: [PATCH v4 02/16] target/riscv: Introduce elp state and enabling controls for zicfilp, Richard Henderson, 2024/08/15
- [PATCH v4 07/16] disas/riscv: enabled `lpad` disassembly, Deepak Gupta, 2024/08/15
  - Re: [PATCH v4 07/16] disas/riscv: enabled `lpad` disassembly, Richard Henderson, 2024/08/16
- [PATCH v4 03/16] target/riscv: save and restore elp state on priv transitions, Deepak Gupta, 2024/08/15
  - Re: [PATCH v4 03/16] target/riscv: save and restore elp state on priv transitions, Richard Henderson, 2024/08/15
    - Re: [PATCH v4 03/16] target/riscv: save and restore elp state on priv transitions, Deepak Gupta <=
- [PATCH v4 04/16] target/riscv: additional code information for sw check, Deepak Gupta, 2024/08/15
- [PATCH v4 01/16] target/riscv: Add zicfilp extension, Deepak Gupta, 2024/08/15
- [PATCH v4 06/16] target/riscv: zicfilp `lpad` impl and branch tracking, Deepak Gupta, 2024/08/15
  - Re: [PATCH v4 06/16] target/riscv: zicfilp `lpad` impl and branch tracking, Richard Henderson, 2024/08/15
- [PATCH v4 05/16] target/riscv: tracking indirect branches (fcfi) for zicfilp, Deepak Gupta, 2024/08/15
  - Re: [PATCH v4 05/16] target/riscv: tracking indirect branches (fcfi) for zicfilp, Richard Henderson, 2024/08/15
    - Re: [PATCH v4 05/16] target/riscv: tracking indirect branches (fcfi) for zicfilp, Deepak Gupta, 2024/08/16
- [PATCH v4 10/16] target/riscv: tb flag for shadow stack instructions, Deepak Gupta, 2024/08/15
- [PATCH v4 12/16] target/riscv: implement zicfiss instructions, Deepak Gupta, 2024/08/15
  - Re: [PATCH v4 12/16] target/riscv: implement zicfiss instructions, Richard Henderson, 2024/08/16

Prev by Date: Re: [PATCH v2 3/4] target/m68k: Implement packed decimal real stores
Next by Date: Re: [PATCH v4 05/16] target/riscv: tracking indirect branches (fcfi) for zicfilp
Previous by thread: Re: [PATCH v4 03/16] target/riscv: save and restore elp state on priv transitions
Next by thread: [PATCH v4 04/16] target/riscv: additional code information for sw check
Index(es):
- Date
- Thread