Re: [PULL 1/5] target/s390x: fix build warning (gcc-12 -fsanitize=thread)

[Thomas Huth]

On 16/08/2024 09.45, Philippe Mathieu-Daudé wrote:
> On 16/8/24 09:22, Thomas Huth wrote:
> > From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> >
> > Found on debian stable.
> >
> > ../target/s390x/tcg/translate.c: In function ‘get_mem_index’:
> > ../target/s390x/tcg/translate.c:398:1: error: control reaches end of 
> > non-void function [-Werror=return-type]
> >    398 | }
> >
> > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> > Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
> > Message-ID: <20240814224132.897098-4-pierrick.bouvier@linaro.org>
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >   target/s390x/tcg/translate.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
> > index c81e035dea..bcfff40b25 100644
> > --- a/target/s390x/tcg/translate.c
> > +++ b/target/s390x/tcg/translate.c
> > @@ -392,7 +392,6 @@ static int get_mem_index(DisasContext *s)
> >           return MMU_HOME_IDX;
> >       default:
> >           g_assert_not_reached();
> > -        break;
>
> Why aren't the other cases problematic?

No clue, but I guess we can tackle them once anybody runs into a problem in 
one of these spots.

 Thomas