qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-9.1 v3 1/2] hw/i386/pc: Unify vmport=auto handling


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-9.1 v3 1/2] hw/i386/pc: Unify vmport=auto handling
Date: Mon, 19 Aug 2024 11:45:01 +0200
User-agent: Mozilla Thunderbird

On 17/8/24 17:25, Kamil Szczęk wrote:
The code which translates vmport=auto to on/off is currently separate
for each PC machine variant, while being functionally equivalent.
This moves the translation into a shared initialization function, while
also tightening the enum assertion.

Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
---
  hw/i386/pc.c      | 5 +++++
  hw/i386/pc_piix.c | 5 -----
  hw/i386/pc_q35.c  | 5 -----
  3 files changed, 5 insertions(+), 10 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]