Re: [PATCH v9 13/17] target/riscv: update `decode_save

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 13/17] target/riscv: update `decode_save_opc` to store ext

From:	Richard Henderson
Subject:	Re: [PATCH v9 13/17] target/riscv: update `decode_save_opc` to store extra word2
Date:	Tue, 27 Aug 2024 10:35:22 +1000
User-agent:	Mozilla Thunderbird

On 8/27/24 01:29, Deepak Gupta wrote:

Extra word 2 is stored during tcg compile and `decode_save_opc` needs
additional argument in order to pass the value. This will be used during
unwind to get extra information about instruction like how to massage
exceptions. Updated all callsites as well.

Signed-off-by: Deepak Gupta<debug@rivosinc.com>
---
  target/riscv/insn_trans/trans_privileged.c.inc |  8 ++++----
  target/riscv/insn_trans/trans_rva.c.inc        |  4 ++--
  target/riscv/insn_trans/trans_rvd.c.inc        |  4 ++--
  target/riscv/insn_trans/trans_rvf.c.inc        |  4 ++--
  target/riscv/insn_trans/trans_rvh.c.inc        |  8 ++++----
  target/riscv/insn_trans/trans_rvi.c.inc        |  6 +++---
  target/riscv/insn_trans/trans_rvvk.c.inc       | 10 +++++-----
  target/riscv/insn_trans/trans_rvzacas.c.inc    |  4 ++--
  target/riscv/insn_trans/trans_rvzfh.c.inc      |  4 ++--
  target/riscv/insn_trans/trans_svinval.c.inc    |  6 +++---
  target/riscv/translate.c                       | 11 ++++++-----
  11 files changed, 35 insertions(+), 34 deletions(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v9 07/17] disas/riscv: enable `lpad` disassembly, (continued)
- [PATCH v9 09/17] target/riscv: introduce ssp and enabling controls for zicfiss, Deepak Gupta, 2024/08/26
- [PATCH v9 12/17] target/riscv: AMO operations always raise store/AMO fault, Deepak Gupta, 2024/08/26
  - Re: [PATCH v9 12/17] target/riscv: AMO operations always raise store/AMO fault, Richard Henderson, 2024/08/26
- [PATCH v9 06/17] target/riscv: zicfilp `lpad` impl and branch tracking, Deepak Gupta, 2024/08/26
  - Re: [PATCH v9 06/17] target/riscv: zicfilp `lpad` impl and branch tracking, Alistair Francis, 2024/08/27
- [PATCH v9 10/17] target/riscv: tb flag for shadow stack instructions, Deepak Gupta, 2024/08/26
  - Re: [PATCH v9 10/17] target/riscv: tb flag for shadow stack instructions, Alistair Francis, 2024/08/27
- [PATCH v9 16/17] disas/riscv: enable disassembly for zicfiss instructions, Deepak Gupta, 2024/08/26
- [PATCH v9 13/17] target/riscv: update `decode_save_opc` to store extra word2, Deepak Gupta, 2024/08/26
  - Re: [PATCH v9 13/17] target/riscv: update `decode_save_opc` to store extra word2, Richard Henderson <=
- [PATCH v9 14/17] target/riscv: implement zicfiss instructions, Deepak Gupta, 2024/08/26
- [PATCH v9 08/17] target/riscv: Add zicfiss extension, Deepak Gupta, 2024/08/26
  - Re: [PATCH v9 08/17] target/riscv: Add zicfiss extension, Alistair Francis, 2024/08/27
- [PATCH v9 11/17] target/riscv: mmu changes for zicfiss shadow stack protection, Deepak Gupta, 2024/08/26
  - Re: [PATCH v9 11/17] target/riscv: mmu changes for zicfiss shadow stack protection, Alistair Francis, 2024/08/27
    - Re: [PATCH v9 11/17] target/riscv: mmu changes for zicfiss shadow stack protection, Deepak Gupta, 2024/08/27
- [PATCH v9 15/17] target/riscv: compressed encodings for sspush and sspopchk, Deepak Gupta, 2024/08/26
  - Re: [PATCH v9 15/17] target/riscv: compressed encodings for sspush and sspopchk, Richard Henderson, 2024/08/26
- [PATCH v9 17/17] disas/riscv: enable disassembly for compressed sspush/sspopchk, Deepak Gupta, 2024/08/26
- Re: [PATCH v9 00/17] riscv support for control flow integrity extensions, Alistair Francis, 2024/08/26

Prev by Date: Re: [PATCH v9 12/17] target/riscv: AMO operations always raise store/AMO fault
Next by Date: Re: [PATCH v9 15/17] target/riscv: compressed encodings for sspush and sspopchk
Previous by thread: [PATCH v9 13/17] target/riscv: update `decode_save_opc` to store extra word2
Next by thread: [PATCH v9 14/17] target/riscv: implement zicfiss instructions
Index(es):
- Date
- Thread