[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC-PATCH v2] vhost-user: add a request-reply lock
|
From: |
Prasad Pandit |
|
Subject: |
Re: [RFC-PATCH v2] vhost-user: add a request-reply lock |
|
Date: |
Tue, 27 Aug 2024 16:29:39 +0530 |
Hello Michael, all
Sorry about a late reply, catching up with emails after long PTOs.
On Mon, 19 Aug 2024 at 21:20, Michael S. Tsirkin <mst@redhat.com> wrote:
>> makes sense.
>> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> But do not post v2 as reply to v1 pls.
* Yes, okay. Thank you for the review. I sent in reply to v1 because
this is a 'RFC' thread and there was no review yet to this series.
* If this V2 patch looks reasonable/acceptable, I'll send this series
for review (without RFC) as V2, if that's okay.
>> Also, looks like this will replace Message-Id:
>> <20240801124540.38774-1-xiangwencheng@dayudpu.com> correct?
* Going through the git logs, vhost_user_set_log_base() sends set log
message only when vq_index==0, so the above patch is not required
IIUC.
->
https://github.com/qemu/qemu/commit/c98ac64cfb53ccb862a80e818c3a19bdd386e61e
===
+ /* Send only once with first queue pair */
+ if (dev->vq_index != 0) {
+ return 0;
+ }
===
Thank you.
---
- Prasad