[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversion
|
From: |
Pavel Pisa |
|
Subject: |
Re: [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversions |
|
Date: |
Thu, 29 Aug 2024 15:17:17 +0200 |
|
User-agent: |
KMail/1.9.10 |
On Tuesday 27 of August 2024 05:49:26 Doug Brown wrote:
> Use QEMU's helper functions can_dlc2len() and can_len2dlc() for
> translating between the raw DLC value and the SocketCAN length value.
> This also has the side effect of correctly handling received CAN FD
> frames with a DLC of 0-8, which was broken previously.
>
> Signed-off-by: Doug Brown <doug@schmorgal.com>
Reviewed-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
--
Pavel Pisa
phone: +420 603531357
e-mail: pisa@cmp.felk.cvut.cz
Department of Control Engineering FEE CVUT
Karlovo namesti 13, 121 35, Prague 2
university: http://control.fel.cvut.cz/
personal: http://cmp.felk.cvut.cz/~pisa
social: https://social.kernel.org/ppisa
projects: https://www.openhub.net/accounts/ppisa
CAN related:http://canbus.pages.fel.cvut.cz/
RISC-V education: https://comparch.edu.cvut.cz/
Open Technologies Research Education and Exchange Services
https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home
- Re: [PATCH v2 2/7] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check, (continued)
- [PATCH v2 3/7] hw/net/can/xlnx-versal-canfd: Translate CAN ID registers, Doug Brown, 2024/08/26
- [PATCH v2 4/7] hw/net/can/xlnx-versal-canfd: Handle flags correctly, Doug Brown, 2024/08/26
- [PATCH v2 7/7] hw/net/can/xlnx-versal-canfd: Fix FIFO issues, Doug Brown, 2024/08/26
- [PATCH v2 5/7] hw/net/can/xlnx-versal-canfd: Fix byte ordering, Doug Brown, 2024/08/26
- [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversions, Doug Brown, 2024/08/26
- Re: [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversions,
Pavel Pisa <=