qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] aspeed: Deprecate the tacoma-bmc machine


From: Cédric Le Goater
Subject: Re: [PATCH v2] aspeed: Deprecate the tacoma-bmc machine
Date: Fri, 30 Aug 2024 10:09:25 +0200
User-agent: Mozilla Thunderbird

Hello,


I solved the problem by adding support for IBM Bonnell (which instantiates
the TPM chip through its devicetree file, similar to tacoma-bmc) to my local
copy of qemu.

Hmm, did you copy the rainier-bmc machine definition ?

For aspeed_machine_bonnell_class_init(), pretty much yes, since I don't know
the actual hardware. For I2C initialization I used the devicetree file.
You can find the patch in the master-local or v9.1.0-local branches
of my qemu clone at https://github.com/groeck/qemu if you are interested.

Oh nice ! Let's merge the IBM Bonnell machine. We can ask IBM to help fixing
the definitions (strapping). Enabling the PCA9554 is good to have too.

Why are you keeping the tmp105 changes ? LGTM. Same for the new tmp models,
they could be upstreamed.


Thanks,

C.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]