[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/4] migration: remove multifd check with postcopy
From: |
Fabiano Rosas |
Subject: |
Re: [PATCH v1 2/4] migration: remove multifd check with postcopy |
Date: |
Tue, 26 Nov 2024 18:12:50 -0300 |
Prasad Pandit <ppandit@redhat.com> writes:
> From: Prasad Pandit <pjp@fedoraproject.org>
>
> Remove multifd capability check with Postcopy mode.
> This helps to enable both multifd and postcopy together.
>
> Signed-off-by: Prasad Pandit <pjp@fedoraproject.org>
> ---
> migration/options.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/migration/options.c b/migration/options.c
> index ad8d6989a8..c498558a85 100644
> --- a/migration/options.c
> +++ b/migration/options.c
> @@ -479,11 +479,6 @@ bool migrate_caps_check(bool *old_caps, bool *new_caps,
> Error **errp)
> error_setg(errp, "Postcopy is not compatible with
> ignore-shared");
> return false;
> }
> -
> - if (new_caps[MIGRATION_CAPABILITY_MULTIFD]) {
> - error_setg(errp, "Postcopy is not yet compatible with multifd");
> - return false;
> - }
This should be squashed into patch 4. We don't want to enable what
doesn't work yet.
> }
>
> if (new_caps[MIGRATION_CAPABILITY_BACKGROUND_SNAPSHOT]) {
[PATCH v1 4/4] migration: enable multifd and postcopy together, Prasad Pandit, 2024/11/26