[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 50/58] pseries: Update SLOF firmware image

From: Paolo Bonzini
Subject: Re: [Qemu-ppc] [PATCH 50/58] pseries: Update SLOF firmware image
Date: Sat, 24 Sep 2011 14:45:20 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2

On 09/20/2011 05:40 AM, David Gibson wrote:
Ah, yes, here's the point.  Updating git.qemu.org is not within my
power, so I can't myself construct a commit doing a submodule + binary
update in this fashion.

Sure you can. A submodule checkout is just like any other git commit. A commit doing a submodule update is just saying "from now on, submodule roms/SLOF is attached to commit 12ab34cd".

First of all, you should configure your qemu tree so that it uses your official upstream repository instead of git.qemu.org's SLOF mirror:

    git config submodule.roms/SLOF.url git://github.com/dgibson/SLOF.git
    rm -rf roms/SLOF
    git submodule update roms/SLOF

Producing a valid patch is as simple as this:

    cd roms/SLOF
    git fetch origin            # if needed
    git checkout origin/master
    cd ..
    cp /path/to/SLOF.bin pc-bios/
    git commit pc-bios roms -m'pseries: Update SLOF firmware image'

Then, whoever updates git.qemu.org indeed has to pull manually from https://github.com/dgibson/SLOF to ensure that git.qemu.org's SLOF mirror does include the new commit. But that doesn't prevent you from *submitting* the patch.

BTW, the above configuration steps should probably be done by everybody who's working with the pseries machine, so that they will have easy access to upstream SLOF bugfixes.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]