[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc sp

From: Stefan Weil
Subject: Re: [Qemu-ppc] [PATCH 2/2] tcg/ppc*: Move cache initialization to ppc specific code
Date: Tue, 04 Oct 2011 07:55:22 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110921 Thunderbird/3.1.15

Am 03.10.2011 23:40, schrieb Scott Wood:
On 10/03/2011 04:10 PM, Stefan Weil wrote:
Am 03.10.2011 22:52, schrieb Scott Wood:
On 10/03/2011 03:43 PM, Stefan Weil wrote:
qemu_cache_utils_init() is only used by ppc / ppc64 tcg targets
to initialize the cache before flush_icache_range() is called.

This patch moves the code to tcg/ppc and tcg/ppc64.
Initialisation is called from tcg_target_init() there.

Signed-off-by: Stefan Weil <address@hidden>

This is not only needed for TCG. We need flush_icache_range() for KVM.
See http://patchwork.ozlabs.org/patch/90403/ and the thread starting
with http://lists.gnu.org/archive/html/qemu-ppc/2011-09/msg00180.html

And must this be duplicated between ppc and ppc64?


Your patch 90403 is obviously still missing in QEMU master -
that's the reason why I did not notice that PPC KVM needs


Alex, is there any objection to merging 90403?

qemu_cache_utils_init() should be called from kvm_init()
and tcg_init() or some function called there

The interface isn't powerpc-specific. It just happens to be the only
arch so far that qemu supports that needs the implementation to do
something (or possibly just the only one where that need has been

What problem is it causing the way it is?

My patch was triggered by this discussion thread and a remark from
Peter Maydell:


The only problem is that ppc differs from all other hosts:

* No other host needs qemu_cache_utils_init() today.

* All other hosts define flush_icache_range() in tcg-target.h.

* All other hosts only call flush_icache_range() from tcg code.

I learned now that ppc will need flush_icache_range() for kvm, too.
So it won't be possible to implement a uniform handling of
flush_icache_range() for all host architectures.

- Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]