[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert

From: Anthony Liguori
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model
Date: Tue, 24 Jan 2012 15:11:45 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110922 Lightning/1.0b2 Thunderbird/3.1.15

On 01/24/2012 03:01 PM, Jan Kiszka wrote:
On 2012-01-24 21:21, Anthony Liguori wrote:
Also, I see a lot of programmatic initialization and a lot of repeating
patterns (specifically regarding trivial class initialization) - there
is no better alternative?

Not really, no.  It looks bad now because you have DeviceInfo still.
Once DeviceInfo goes away, all of the initialization will happen in the
class_init function.

The design of QOM is such that a lot of what was previously done via
declarative structures is now done imperatively.  But the code bloat
that came in this patch series will decrease significantly with the next
series as we eliminate DeviceInfo.

Are there examples of fully converted devices to get an impression?


Has everything fully converted (including BusState).

If you look at qdev.[ch], you'll notice the remaining qdev infrastructure becomes greatly simplified.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]