[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Objec

From: Jan Kiszka
Subject: Re: [Qemu-ppc] [PATCH 27/28] sysbus: apic: ioapic: convert to QEMU Object Model
Date: Tue, 24 Jan 2012 22:01:28 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv: Gecko/20080226 SUSE/ Thunderbird/ Mnenhy/

On 2012-01-24 21:21, Anthony Liguori wrote:
>> Also, I see a lot of programmatic initialization and a lot of repeating
>> patterns (specifically regarding trivial class initialization) - there
>> is no better alternative?
> Not really, no.  It looks bad now because you have DeviceInfo still. 
> Once DeviceInfo goes away, all of the initialization will happen in the
> class_init function.
> The design of QOM is such that a lot of what was previously done via
> declarative structures is now done imperatively.  But the code bloat
> that came in this patch series will decrease significantly with the next
> series as we eliminate DeviceInfo.

Are there examples of fully converted devices to get an impression?


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]