[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 7/7] pseries: Configure PCI bridge us

From: David Gibson
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 7/7] pseries: Configure PCI bridge using properties
Date: Tue, 6 Mar 2012 16:22:51 +1100
User-agent: Mutt/1.5.21 (2010-09-15)

On Sat, Mar 03, 2012 at 07:42:09PM +0100, Andreas Färber wrote:
> Am 28.02.2012 04:18, schrieb David Gibson:
> > From: Alexey Kardashevskiy <address@hidden>
> > -    QLIST_INSERT_HEAD(&spapr->phbs, phb, list);
> > +type_init(spapr_register_pci_type)
> Please respect the recently enforced convention of naming the function
> ..._register_types as before and best putting it and type_init() in the
> bottom so that we don't end up with multiple ones per file.

Now that I'm aware of the convention, sure.

> And registering types is all such a function can safely do since the
> call of these constructors is about to be moved (spapr_rtas_register
> looks fishy in that aspect).

Ok, I'll do the rename and move the rtas register calls into the
class_init function and respin.

David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]