[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_i

From: David Gibson
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io
Date: Wed, 28 Mar 2012 02:14:53 +1100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Mar 27, 2012 at 04:43:25PM +0200, Kevin Wolf wrote:
> Am 27.03.2012 16:30, schrieb Andreas Färber:
> > Am 27.03.2012 04:42, schrieb David Gibson:
> >> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to
> >> determine the direction of DMA it is emulating.  We already have a
> >> DMADirection enum designed specifically to encode DMA directions.
> >> This patch uses it for dma_bdrv_io() as well.  This involves removing
> >> the DMADirection definition from the #ifdef it was inside, but since that
> >> only existed to protect the definition of dma_addr_t from places where
> >> config.h is not included, there wasn't any reason for it to be there in
> >> the first place.
> >>
> >> Cc: Kevin Wolf <address@hidden>
> >>
> >> Signed-off-by: David Gibson <address@hidden>
> > 
> > Including for ppc macio in absence of Alex,
> > 
> > Reviewed-by: Andreas Färber <address@hidden>
> > 
> > (Expecting this to go through IDE/Kevin's tree.)
> So this isn't part of another series any more?

There's still some stuff to work on in that series, but these early
patches from it are ready to go, so I thought I'd try to get them in

David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]