[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of more PPC64 insns (PATC

From: Torbjorn Granlund
Subject: Re: [Qemu-ppc] [Qemu-devel] Incorrect handling of more PPC64 insns (PATCH)
Date: Wed, 08 May 2013 12:07:04 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (berkeley-unix)

Alexander Graf <address@hidden> writes:

  Ok, so the real problem here is that NARROW_MODE is not set, but is
  used to differentiate whether to use the 32bit cmp only or not.

  Richard, there are 2 ways out of this:
    1) get rid of NARROW_MODE and always check ctx->sf


The cmp insn with L set should NOT be affected by SF.  That's the entire
point of my change.

I reviewed the other uses of NARROW_MODE and didn't spot any errors.
(But I must confess that I would need to red the PPC manuals better inn
order to tell for sure.)

    2) add a new 32bit only insns flag and create separate functions for 32bit 
cmp calls
Aurelien's patch looked promising, if one removes the exception casting.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]