[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [RFC PATCH] spapr-vscsi: add task management

From: Alexey Kardashevskiy
Subject: Re: [Qemu-ppc] [RFC PATCH] spapr-vscsi: add task management
Date: Mon, 22 Jul 2013 10:57:37 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6

On 07/22/2013 10:23 AM, Benjamin Herrenschmidt wrote:
> On Mon, 2013-07-22 at 10:20 +1000, Alexey Kardashevskiy wrote:
>> May be. But there was no way to get this callback called till I started
>> calling scsi_req_cancel in this patch so I would not split.
> You probably still should. The smaller each individual patch, the better
> (in part because that makes them easier to review).

Should make it easier but in fact it does not for me :)

> So a first patch adding the new callback, then a second patch adding the
> task management.

I can even add tasks one-by-one :)

Come on, is this patch really big or even close to be called big?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]