[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-ppc] [PATCH for-1.6 0/2] Fix clang warnings in linux-user signal c

From: Peter Maydell
Subject: [Qemu-ppc] [PATCH for-1.6 0/2] Fix clang warnings in linux-user signal code
Date: Mon, 29 Jul 2013 12:00:30 +0100

These two patches fix some clang warnings about use of uninitialized
data in linux-user's signal related code for PPC and ARM. The issue
in both cases is the same: a code path taken in case of failure was
doing 'unlock_user_struct()' with parameters which hadn't yet been
set up.

I've marked this as for-1.6 because the patches are simple and I
think it's nice to get rid of warnings. However, they're not critical
for 1.6:
 * the existing code will be OK because unlock_user_struct() is
   a no-op unless DEBUG_REMAP is defined
 * clang isn't our primary compiler on Linux
 * configure (kind of inadvertently) disables -Werror for clang
 * there are other warnings not yet fixed anyhow (most notably
   all the places which use 'dprintf' as a debug macro despite
   that being the name of a POSIX specified function)

Peter Maydell (2):
  linux-user/signal.c: PPC: Silence clang uninitialized-use warning
  linux-user/signal.c: Avoid using uninitialized data in ARM sigreturn

 linux-user/signal.c |   38 +++++++++++++++++++++-----------------
 1 file changed, 21 insertions(+), 17 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]