[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] Adds the ability to use the comma

From: Programmingkid
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] Adds the ability to use the command key in the guest operating system.
Date: Sat, 3 Aug 2013 19:43:21 -0400

On Aug 3, 2013, at 7:06 PM, Peter Maydell wrote:

> On 3 August 2013 23:52, G 3 <address@hidden> wrote:
>> This patch adds the ability to use the command key in the guest
>> operating system. Just add -command-key 55 to the command line
>> options sent to QEMU to use this feature.
>> I have checked the patch by sending it thru checkpatch.pl this time. I also
>> made a bunch of style changes to more closely match QEMU's suggested coding
>> style.
>> signed-off-by: John Arbuckle <address@hidden>
>> ---
>> ui/cocoa.m |  114
>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++-----
>> 1 files changed, 104 insertions(+), 10 deletions(-)
> This definitely isn't "trivial".
> I'm also really unconvinced that this is the right way to handle
> this: adding a new cocoa-UI-only command line option which takes
> a magic number looks very odd.
> thanks
> -- PMM

Why don't you think it is trivial? There aren't many cocoa-ui users. This patch 
falls into a very small and little used area of QEMU. I think that makes this 
patch a trivial one. 

The way of how to handle send the command key into the guest operating system 
has already been discussed. This way lets the user decide at runtime how best 
to handle the command key. The magic number you talk about is actually a 
virtual key value. Every key has their own virtual key.

Do you have your own idea as to how to handle the command key? 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]