[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v2 05/10] raven: set a correct PCI I/O memory regi

From: Paolo Bonzini
Subject: Re: [Qemu-ppc] [PATCH v2 05/10] raven: set a correct PCI I/O memory region
Date: Wed, 04 Sep 2013 10:11:47 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

Il 04/09/2013 09:22, Peter Maydell ha scritto:
> > Not using address_space_io is fine as well, but it's a separate change
> > and I doubt it is a good idea to do it for a single target; if you do it
> > for all non-x86 PCI bridges, and move the initialization of
> > address_space_io to target-i386, that's a different story of course.
> What's the problem with doing it for a single target? That's
> what I did for versatilepb. I think any CPU that doesn't have
> inb/outb type instructions (x86 does, and I think also alpha
> but I forget)

Actually, Alpha is also not using address_space_io at all as far as I
can see.

> should not be using address_space_io; but the
> easiest way to get there is to convert the PCI bridges one at
> a time as we have maintenance effort to do so.

I'm not against the patch, but there are less than ten host bridges and
most of them should be tested by "make check", so I would prefer to have
a plan for making things consistent.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]