[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v2 05/10] raven: set a correct PCI I/O memory regi

From: Hervé Poussineau
Subject: Re: [Qemu-ppc] [PATCH v2 05/10] raven: set a correct PCI I/O memory region
Date: Mon, 09 Sep 2013 22:57:15 +0200
User-agent: Thunderbird (Windows/20090812)

Peter Maydell a écrit :
On 4 September 2013 09:11, Paolo Bonzini <address@hidden> wrote:
Il 04/09/2013 09:22, Peter Maydell ha scritto:
should not be using address_space_io; but the
easiest way to get there is to convert the PCI bridges one at
a time as we have maintenance effort to do so.
I'm not against the patch, but there are less than ten host bridges and
most of them should be tested by "make check", so I would prefer to have
a plan for making things consistent.

My plan for that goes:
 1. where people are overhauling a host bridge (ie in a patchset like
     this one) allow them to make the changes that move in the right
 2. look at how many other bridges remain after that
 3. fix the other bridges if anybody has time and effort

(Does 'make check' really test all the host bridges? This doesn't
seem very likely to me.)

Paolo, Peter, so, did we raise some consensus? Should I reuse get_system_io(), or having a separate MemoryRegion is acceptable? I think that creating a independant MemoryRegion is better, as I see no reason why QEMU should provide a global I/O region, which has some sense mostly on x86 architectures only. However, I can rework patches to use get_system_io() if that's what you prefer...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]