Re: [Qemu-ppc] [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd Instruction

[Richard Henderson]

On 12/09/2013 07:46 AM, Tom Musta wrote:
> +    for (i = 0; i < 8; i++) {
> +        int index = (rs & (0xFFul) << (i*8)) >> (i*8);

This is a silly expression.  Better as

    int index = (rs >> (i * 8)) & 0xff;

> +                ra |= (1<<i);

Unnecessary parens, and missing spaces around the operator.


r~