|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-ppc] [PATCH] roms: Flush icache when writing roms to guest memory |
| Date: | Wed, 11 Dec 2013 14:27:35 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 11/12/2013 14:23, Alexander Graf ha scritto:
> + if (kvm_enabled()) {
> + /*
> + * The guest may want to directly execute from the rom
> region,
> + * so we better invalidate its icache
> + */
> + flush_icache_range((uintptr_t)ptr, (uintptr_t)ptr + l);
> + }
Shouldn't KVM itself do that when a memslot is registered? There should
be no reason for non-TCG QEMU to flush the icache.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |