[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Sma

From: Peter Maydell
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Small Negatives in float64_to_uint64
Date: Fri, 13 Dec 2013 00:13:28 +0000

On 9 December 2013 15:47, Tom Musta <address@hidden> wrote:
> The float64_to_uint64 routine exits early for all negative numbers.
> While the integer result is always correctly returned as 0, the
> exception flags are also always set to float_flag_invalid.  This
> is incorrect for those cases where a small negative number (-1 < x < 0)
> rounds to zero.  In such a case, the flag should be reported as
> inexact.

> -static int64 roundAndPackUint64(uint64_t absZ0, uint64_t absZ1 STATUS_PARAM)
> +static int64 roundAndPackUint64(flag zSign, uint64_t absZ0,
> +                                uint64_t absZ1 STATUS_PARAM)

This function isn't in the copy of fpu/softfloat.c that's in master,
unless I'm confused. Does this series depend on something else?

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]