[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v3 00/10] prep: improve Raven PCI host emulation

From: Andreas Färber
Subject: Re: [Qemu-ppc] [PATCH v3 00/10] prep: improve Raven PCI host emulation
Date: Mon, 23 Dec 2013 01:52:09 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

Am 05.11.2013 00:09, schrieb Hervé Poussineau:
> Hervé Poussineau (10):
>   prep: kill get_system_io() usage
>   raven: use constant PCI_NUM_PINS instead of 4

Thanks and sorry for the delay, I've applied these to prep-up:
(An intermittent memory'ish regression has been fixed now apparently.)

>   raven: move BIOS loading from board code to PCI host

Hearing no objections or comments on this approach of loading firmware
in the PCI host bridge device, we have discussed that I'll be accepting
it to allow for easy sharing between in-tree and upcoming PReP machines.

However I'm still struggling to understand another aspect of the patch,
question inline.


>   raven: rename intack region to pci_intack
>   raven: set a correct PCI I/O memory region
>   raven: set a correct PCI memory region
>   raven: add PCI bus mastering address space
>   raven: implement non-contiguous I/O region
>   raven: fix PCI bus accesses with size > 1
>   raven: use raven_ for all function prefixes
>  hw/pci-host/prep.c |  235 
> ++++++++++++++++++++++++++++++++++++++++++++--------
>  hw/ppc/prep.c      |  155 ++++++----------------------------
>  2 files changed, 226 insertions(+), 164 deletions(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]