[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] PPC: sPAPR: Only use getpagesize() when we run wi

From: Peter Maydell
Subject: Re: [Qemu-ppc] [PATCH] PPC: sPAPR: Only use getpagesize() when we run with kvm
Date: Fri, 21 Feb 2014 10:36:56 +0000

On 21 February 2014 09:41, Alexander Graf <address@hidden> wrote:
> We currently size the msi window trap page according to the host's page
> size so that we poke a working hole into a memory slot in case we overlap.
> However, this is only ever necessary with KVM active. Without KVM, we should
> rather try to be host platform agnostic and use a constant size: 4k.
> This fixes a build breakage on win32 hosts.

Unfortunately it doesn't:

cam-vm-266:precise:qemu$ make -C build/w32
make: Entering directory `/home/petmay01/linaro/qemu-from-laptop/qemu/build/w32'
  CC    ppc64-softmmu/hw/ppc/spapr_pci.o
cc1: warnings being treated as errors
/home/petmay01/linaro/qemu-from-laptop/qemu/hw/ppc/spapr_pci.c: In
function ‘spapr_pci_msi_init’:
warning: implicit declaration of function ‘getpagesize’
warning: nested extern declaration of ‘getpagesize’

The compiler complains that there's no declaration
of the function you're trying to call before it gets
around to deciding whether it can eliminate the code
as unreachable.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]