Re: [Qemu-ppc] [PULL 125/130] target-ppc: Fix page table lookup with kvm enabled

[Paolo Bonzini]

Il 14/03/2014 14:13, Aneesh Kumar K.V ha scritto:
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index e999bbaea062..e079be050fc7 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -118,7 +118,8 @@ static target_ulong h_enter(PowerPCCPU *cpu, 
> sPAPREnvironment *spapr,
>              if ((ppc_hash64_load_hpte0(env, token, index) & HPTE64_V_VALID) == 
> 0) {
>                  break;
>              }
> -        } while (index++);
> +            index++;
> +        } while (1);

Better use for or while() than do...while, or it could also be

        token = ppc_hash64_start_access(cpu, pte_index);
        for (; index < 8; i++, hpte += HASH_PTE_SIZE_64) {
           ...
        }
        ppc_hash64_stop_access(token);
        if (index == 8) {
            return H_PTEG_FULL;
        }

Paolo

>          ppc_hash64_stop_access(token);
>      } else {
>          token = ppc_hash64_start_access(cpu, pte_index);
>
>          -aneesh