qemu-ppc
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] target-ppc: Eliminate Magic Number MSR Masks

From: Alexander Graf
Subject: Re: [Qemu-ppc] [PATCH] target-ppc: Eliminate Magic Number MSR Masks
Date: Wed, 16 Apr 2014 12:40:54 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 

On 15.04.14 19:21, Tom Musta wrote:

Use MSR mnemonics from cpu.h instead of magic numbers for the 
CPUPPCState.msr_mask
initialization.

There is one bit in the 401x2 (and subsequent) model that I could not find any
documentation for.  It is open coded at little endian bit position 20:

     pcc->msr_mask = (1ull << 20) |
                     (1ull << MSR_KEY) |
                     (1ull << MSR_POW) |
                     (1ull << MSR_CE) |
                     ...

Signed-off-by: Tom Musta <address@hidden>


Thanks a lot for the cleanup!

Applied to ppc-next.


Alex
reply via email to
[Prev in Thread] Current Thread [Next in Thread]