[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 7/9] PPC: e500: Support dynamically spawned sys
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [PATCH v2 7/9] PPC: e500: Support dynamically spawned sysbus devices |
Date: |
Wed, 30 Jul 2014 15:55:56 +0100 |
On 2 July 2014 19:01, Alexander Graf <address@hidden> wrote:
> For e500 our approach to supporting dynamically spawned sysbus devices is to
> create a simple bus from the guest's point of view within which we map those
> devices dynamically.
>
> + /* Connect sysbus device to virtual platform bus */
> + for (i = 0; i < sbdev->num_irq; i++) {
> + if (!sbdev->irqp[i]) {
> + /* This IRQ is an incoming IRQ, we can't wire those here */
I don't understand this comment -- sysbus IRQs are all outbound
by definition. Lines going in to a device are GPIOs. (Ideally we
should get rid of "sysbus IRQs" completely and just use named
inbound GPIOs for everything.)
Also, sbdev->irqp[] is private to the sysbus implementation, so
you shouldn't be fishing about in it in the platform code.
thanks
-- PMM
- [Qemu-ppc] [PATCH v2 0/9] Dynamic sysbus device allocation support, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 2/9] qom: macroify integer property helpers, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 4/9] qom: Add generic object property g_free helper, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 7/9] PPC: e500: Support dynamically spawned sysbus devices, Alexander Graf, 2014/07/02
- Re: [Qemu-ppc] [PATCH v2 7/9] PPC: e500: Support dynamically spawned sysbus devices,
Peter Maydell <=
- [Qemu-ppc] [PATCH v2 8/9] e500: Add support for eTSEC in device tree, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 6/9] sysbus: Make devices spawnable via -device, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 9/9] PPC: Fix default config ordering and add eTSEC for ppc64, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 1/9] qom: Move property helpers to own file, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 5/9] sysbus: Add user map hints, Alexander Graf, 2014/07/02
- [Qemu-ppc] [PATCH v2 3/9] qom: Expose property helpers for get/set of integers, Alexander Graf, 2014/07/02