[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] target-ppc: Cast ssize_t to size

From: Peter Maydell
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] target-ppc: Cast ssize_t to size_t before printing with %zx
Date: Tue, 23 Dec 2014 22:47:49 +0000

On 23 December 2014 at 22:36, Stefan Weil <address@hidden> wrote:
> Am 23.12.2014 um 23:22 schrieb Peter Maydell:
>> --- a/hw/ppc/spapr.c
>> +++ b/hw/ppc/spapr.c
>> @@ -1438,7 +1438,7 @@ static void ppc_spapr_init(MachineState *machine)
>>       }
>>       if (spapr->rtas_size > RTAS_MAX_SIZE) {
>>           hw_error("RTAS too big ! 0x%zx bytes (max is 0x%x)\n",
>> -                 spapr->rtas_size, RTAS_MAX_SIZE);
>> +                 (size_t)spapr->rtas_size, RTAS_MAX_SIZE);
>>           exit(1);
>>       }
>>       g_free(filename);
> Which compiler did you use? I get no warning with Debian's
> x86_64-w64-mingw32-gcc 4.6.3 or
> native MinGW-w32 compilers.

$ i586-mingw32msvc-gcc --version
i586-mingw32msvc-gcc (GCC) 4.2.1-sjlj (mingw32-2)

Yes, this is ancient... it's from the Debian mingw32 package.
I just use this for compile testing, not for trying to run.
I should probably switch to the w64 compiler for build tests;
I forget now if there was a reason why I hadn't.

I suspect, as I say, that this is just a generic old-gcc bug,
but it's the only one in the codebase, so it seems easiest
just to fix it.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]