Re: [Qemu-ppc] [Qemu-devel] [PATCHv2 7/7] openpic: fix up loadvm under -M mac99

[Mark Cave-Ayland]

On 22/01/15 13:39, Alexander Graf wrote:

> On 21.01.15 17:01, Mark Cave-Ayland wrote:
>> Issuing loadvm under -M mac99 would fail for two reasons: firstly an 
>> incorrect
>> version number for openpic would cause openpic_load() to abort, and secondly
>> a cut/paste error when restoring the IVPR and IDR registers caused subsequent
>> vmstate sections to become misaligned and abort early.
>>
>> Signed-off-by: Mark Cave-Ayland <address@hidden>
> 
> Thanks a lot for all the work you put into this. Do you think you
> understand enough to the OpenPIC code by now to be able to convert it to
> VMState instead?
> 
> That would get rid of the whole class of problems altogether and make
> sure we didn't overlook something subtle somewhere else in the code.

I'm interested to have a go in time for the 2.3 release, but I'm not
exactly sure when that will be. This was mainly a festive distraction in
an attempt to help work out why the existing macio code doesn't work
correctly in its current form.

I'd be fine with you applying the existing patchset and I'll submit an
attempt to convert to VMState a bit later, hopefully after your
migration stream patches have also been merged to make the job a bit
easier ;)

Also slightly off-topic, but my rework of the macio code
(https://github.com/mcayland/qemu/commits/for-kevin), while being much
more readable in my opinion, also sadly appears to suffer from the same
corruption bug as the existing implementation.

If you think that what I have there is an improvement in terms of
readability then I'll aim to get that tidied up and submitted at some
point during the 2.3 cycle too.


ATB,

Mark.