[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH] target-ppc: Use right page size with

From: David Gibson
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH] target-ppc: Use right page size with hash table lookup
Date: Thu, 29 Jan 2015 11:48:47 +1100
User-agent: Mutt/1.5.23 (2014-03-12)

On Mon, Jan 26, 2015 at 07:51:58PM +0530, Aneesh Kumar K.V wrote:
> We look at two sizes specified in ISA (4K, 64K). If not found matching,
> we consider it 16MB.
> Without this patch we would fail to lookup address above 16MB range.
> Below 16MB happened to work before because the kernel have a liner
> mapping and we always looked up hash for 0xc000000000000000. The
> actual real address was computed by using the 16MB offset
> with the real address found with the above hash.
> Without Fix:
> (gdb) x/16x 0xc000000001000000
> 0xc000000001000000 <list_entries+453208>:       Cannot access memory at 
> address 0xc000000001000000
> (gdb)
> With Fix:
> (gdb)  x/16x 0xc000000001000000
> 0xc000000001000000 <list_entries+453208>:       0x00000000      0x00000000    
>   0x00000000      0x00000000
> 0xc000000001000010 <list_entries+453224>:       0x00000000      0x00000000    
>   0x00000000      0x00000000
> 0xc000000001000020 <list_entries+453240>:       0x00000000      0x00000000    
>   0x00000000      0x00000000
> 0xc000000001000030 <list_entries+453256>:       0x00000000      0x00000000    
>   0x00000000      0x00000000
> Signed-off-by: Aneesh Kumar K.V <address@hidden>

This doesn't fully implement the sllp page size encodings, but it's
certainly better than what's there now.

Reviewed-by: David Gibson <address@hidden>

David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!

Attachment: pgpFgB_IIZB9z.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]