[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 5/7] memory: Allow replay of IOMMU mapping notific

From: Paolo Bonzini
Subject: Re: [Qemu-ppc] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications
Date: Tue, 29 Sep 2015 09:15:58 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 29/09/2015 05:30, David Gibson wrote:
>> Maybe...  The only issue is the "granularity" argument, which is 
>> not in memory_region_register_iommu_notifier.  That makes me
>> wonder if the replay and registration make sense as separate
>> operations.
>> What about adding a new function memory_region_iommu_replay and 
>> separate the two phases?
> Hm.. I'm not sure I see much advantage to separating the phases.

It's just that it's (IMO) the clearest API.  It shows how the
granularity is only used for replay.

> But I don't particularly object to the idea either.  So, I think
it's your
> call.

Yes, let's separate it.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]