[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_r

From: Paolo Bonzini
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init
Date: Wed, 30 Sep 2015 15:03:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 30/09/2015 10:57, Markus Armbruster wrote:
> Paolo Bonzini <address@hidden> writes:
>> > This causes the region to outlive the object, because it attaches the
>> > region to /machine.  This is not nice for the "realize" method, but
>> > much worse for "instance_init" because it can cause dangling pointers
>> > after a simple object_new/object_unref pair.
>> >
>> > Reported-by: Markus Armbruster <address@hidden>
>> > Signed-off-by: Paolo Bonzini <address@hidden>
> One more: pxa2xx_pcmcia_initfn().
> The ones you fix are
> Tested-by: Markus Armbruster <address@hidden>

Can you fix it up and take it through your series?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]