[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error ar

From: Markus Armbruster
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct
Date: Mon, 01 Feb 2016 14:07:50 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> No backend was setting an error when ending an implicit struct,
> or when iterating a list.

Perhaps "when ending the visit of a list or implicit struct, or when
moving to the next list node" would be more precise.  If you like it, I
can do that on commit.

>                            Make the callers a bit easier to follow
> by making this a part of the contract, and removing the errp
> argument - callers can then unconditionally end an object as
> part of cleanup without having to think about whether a second
> error is dominated by a first, because there is no second error.
> A later patch will then tackle the larger task of splitting
> visit_end_struct(), which can indeed set an error (and that
> cleanup will also have the side-effect of removing the use of
> error_abort added here).
> Signed-off-by: Eric Blake <address@hidden>
> ---
> v10: split out qmp input changes, also fix visit_next_list(), drop R-b
> v9: enhance commit message
> v8: no change
> v7: place earlier in series, rebase to earlier changes
> v6: new patch, split from RFC on v5 7/46

Patch looks good.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]