[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error ar

From: Eric Blake
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct
Date: Mon, 1 Feb 2016 16:14:32 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 02/01/2016 06:07 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>> No backend was setting an error when ending an implicit struct,
>> or when iterating a list.
> Perhaps "when ending the visit of a list or implicit struct, or when
> moving to the next list node" would be more precise.  If you like it, I
> can do that on commit.
>>                            Make the callers a bit easier to follow
>> by making this a part of the contract, and removing the errp
>> argument - callers can then unconditionally end an object as
>> part of cleanup without having to think about whether a second
>> error is dominated by a first, because there is no second error.
>> A later patch will then tackle the larger task of splitting
>> visit_end_struct(), which can indeed set an error (and that
>> cleanup will also have the side-effect of removing the use of
>> error_abort added here).

Oh, while you're touching this up, the last half of this sentence is now
stale (since the addition of &error_abort was split out into 22/25
instead); I'd just delete the entire parenthetical, ending with "indeed
set an error."

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]