[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-ppc] [PATCH] hw/ppc/spapr: Halt CPU when powering off via RTAS cal

From: Thomas Huth
Subject: [Qemu-ppc] [PATCH] hw/ppc/spapr: Halt CPU when powering off via RTAS call
Date: Wed, 17 Feb 2016 19:23:19 +0100

The LoPAPR specification defines the following for the RTAS
power-off call: "On successful operation, does not return".
However, the implementation in QEMU currently returns and runs
the guest CPU again for some more cycles. This caused some
trouble with the new ppc implementation of the kvm-unit-tests
recently. So let's make sure that the QEMU implementation
follows the spec, thus stop the CPU to make sure that the
RTAS call does not return to the guest anymore.

Signed-off-by: Thomas Huth <address@hidden>
 hw/ppc/spapr_rtas.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
index 07ad672..b7c5ebd 100644
--- a/hw/ppc/spapr_rtas.c
+++ b/hw/ppc/spapr_rtas.c
@@ -113,6 +113,7 @@ static void rtas_power_off(PowerPCCPU *cpu, 
sPAPRMachineState *spapr,
+    cpu_stop_current();
     rtas_st(rets, 0, RTAS_OUT_SUCCESS);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]