[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCHv2 3/7] spapr_pci: Eliminate class callbacks

From: Alexey Kardashevskiy
Subject: Re: [Qemu-ppc] [PATCHv2 3/7] spapr_pci: Eliminate class callbacks
Date: Mon, 29 Feb 2016 18:28:02 +1100
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 02/29/2016 06:06 PM, David Gibson wrote:
The EEH operations in the spapr-vfio-pci-host-bridge no longer rely on the
special groupid field in sPAPRPHBVFIOState.  So we can simplify, removing
the class specific callbacks with direct calls based on a simple
spapr_phb_eeh_enabled() helper.  For now we implement that in terms of
a boolean in the class, but we'll continue to clean that up later.

On its own this is a rather strange way of doing things, but it's a useful
intermediate step to further cleanups.

Signed-off-by: David Gibson <address@hidden>

Reviewed-by: Alexey Kardashevskiy <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]