[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [RFC PATCH] pseries: use qemu_irq_raise() in spapr_msi_wr

From: Alexey Kardashevskiy
Subject: Re: [Qemu-ppc] [RFC PATCH] pseries: use qemu_irq_raise() in spapr_msi_write()
Date: Tue, 10 May 2016 11:31:50 +1000
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

On 05/10/2016 11:18 AM, Li Zhong wrote:
It seems that both ics_set_irq() and ics_kvm_set_irq() don't do anything
useful for MSIs with val = 0, so maybe the pulse in spapr_msi_write()
could be replaced with a single raise?

qemu_irq_raise() needs matching qemu_irq_lower(), where is it?

Signed-off-by: Li Zhong <address@hidden>
 hw/ppc/spapr_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 573e635..897c541 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -732,7 +732,7 @@ static void spapr_msi_write(void *opaque, hwaddr addr,

     trace_spapr_pci_msi_write(addr, data, irq);

-    qemu_irq_pulse(xics_get_qirq(spapr->icp, irq));
+    qemu_irq_raise(xics_get_qirq(spapr->icp, irq));

 static const MemoryRegionOps spapr_msi_ops = {


reply via email to

[Prev in Thread] Current Thread [Next in Thread]