Re: [Qemu-ppc] [PATCH v5 4/4] adb.c: prevent NO_KEY value from going to guest

[BALATON Zoltan]

On Wed, 17 Aug 2016, John Arbuckle wrote:
> @@ -446,7 +438,10 @@ static void adb_keyboard_event(DeviceState *dev, 
> QemuConsole *src,
>         return;
>     }
>     keycode = qcode_to_adb_keycode[qcode];
> -
> +    if (keycode == NO_KEY) {  /* We don't want to send this to the guest */
> +        ADB_DPRINTF("Ignoring NO_KEY\n");
> +        return;
> +    }
>     if (evt->u.key.data->down == false) { /* if key release event */
>         keycode = keycode | 0x80;   /* create keyboard break code */
>     }

I think you should print the qcode value that was ignored instead of that 
it was mapped to NO_KEY which is not that informative.

Regards,
BALATON Zoltan